Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8989
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 33095fc with merge base 6170804 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
approved these changes
Mar 6, 2025
Contributor
|
Before merging, let's import to |
Contributor
|
@SamGondelman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SamGondelman
added a commit
to SamGondelman/executorch
that referenced
this pull request
Mar 6, 2025
Summary: fix from pytorch#8989 Reviewed By: SS-JIA Differential Revision: D70680840
Closed
Closed
SS-JIA
pushed a commit
to SS-JIA/executorch-1
that referenced
this pull request
Mar 6, 2025
Summary: fix from pytorch#8989 Reviewed By: SS-JIA Differential Revision: D70680840
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#8916 broke tests. mman.h is needed by mmap_data_loader_test.cpp, and we need to use select
Test plan
Unit tests - not sure why this didn't show on the first PR?