Remove tombstone messages proactively#8703
Merged
facebook-github-bot merged 1 commit intomainfrom Mar 26, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8703
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 55d61f1 with merge base 265b9b7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69994481 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 25, 2025
Summary: X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Differential Revision: D69994481
swolchok
approved these changes
Feb 25, 2025
| @@ -1,9 +1,10 @@ | |||
| load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") | |||
Contributor
There was a problem hiding this comment.
I don't love that this file is not available in the open-source shim. however, they are not building in OSS today, so I won't block.
bigfootjon
added a commit
that referenced
this pull request
Feb 27, 2025
Summary: X-link: pytorch/pytorch#147897 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Differential Revision: D69994481
8282edf to
cd30edf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69994481 |
bigfootjon
added a commit
that referenced
this pull request
Feb 27, 2025
Summary: X-link: pytorch/pytorch#147897 Pull Request resolved: #8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Differential Revision: D69994481
cd30edf to
9a33ba3
Compare
bigfootjon
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: #147897 X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Differential Revision: D69994481
bigfootjon
added a commit
that referenced
this pull request
Mar 19, 2025
Summary: X-link: pytorch/pytorch#147897 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Differential Revision: D69994481
9a33ba3 to
b0cfc8c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69994481 |
bigfootjon
added a commit
that referenced
this pull request
Mar 19, 2025
Summary: X-link: pytorch/pytorch#147897 Pull Request resolved: #8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Differential Revision: D69994481
b0cfc8c to
fda6b88
Compare
bigfootjon
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 19, 2025
Summary: Pull Request resolved: #147897 X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Differential Revision: D69994481
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Summary: X-link: pytorch/pytorch#147897 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Differential Revision: D69994481
fda6b88 to
77da3aa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69994481 |
bigfootjon
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 25, 2025
Summary: Pull Request resolved: #147897 X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Reviewed By: mzlee Differential Revision: D69994481
bigfootjon
added a commit
that referenced
this pull request
Mar 26, 2025
Summary: X-link: pytorch/pytorch#147897 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Reviewed By: mzlee Differential Revision: D69994481
77da3aa to
5db1d48
Compare
Summary: X-link: pytorch/pytorch#147897 Pull Request resolved: #8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Reviewed By: mzlee Differential Revision: D69994481
bigfootjon
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 26, 2025
Summary: Pull Request resolved: #147897 X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Reviewed By: mzlee Differential Revision: D69994481
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69994481 |
5db1d48 to
55d61f1
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 26, 2025
Summary: X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Differential Revision: D69994481 Pull Request resolved: #147897 Approved by: https://github.com/izaitsevfb
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D69994481 Pull Request resolved: #8703
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Summary: X-link: pytorch/executorch#8703 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Test Plan: CI Differential Revision: D69994481 Pull Request resolved: pytorch#147897 Approved by: https://github.com/izaitsevfb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Originally we created a bunch of empty
TARGETSfiles to allow us to enableBUCKfiles in fbcode by hiding the existing BUCK file. These files were subsequently merged together usingnon_fbcode_targetso these tombstones are no longer necessary.This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with
sed,arc fand reverted any lines that didn't make senseDifferential Revision: D69994481