s/ifdef ET_LOG_ENABLED/if ET_LOG_ENABLED/#8403
Merged
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8403
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d5887fc with merge base ee7d388 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 12, 2025
cccclai
approved these changes
Feb 12, 2025
Contributor
cccclai
left a comment
There was a problem hiding this comment.
This PR seems reasonable but not sure how it fixes the CI..
Contributor
Author
when ET_LOG_DISABLED was defined to 0 (disabling logging), we were creating the strings to log (gated on #ifdef) but ET_LOG itself was disabled (gated on #if), so the strings were unused, triggering -Wunused-variable. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Looks like we define it to 0 rather than leaving it undefined to disable. ghstack-source-id: 71cf766 ghstack-comment-id: 2652545958 Pull Request resolved: pytorch/executorch#8403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we define it to 0 rather than leaving it undefined to disable.