Skip to content

Use tensor_shape_to_c_string for error in check_glu_args#8316

Merged
swolchok merged 8 commits intomainfrom
gh/swolchok/237/head
Feb 13, 2025
Merged

Use tensor_shape_to_c_string for error in check_glu_args#8316
swolchok merged 8 commits intomainfrom
gh/swolchok/237/head

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 7, 2025

Rolling out for #7902

@swolchok
Update
bf1ead9 
[ghstack-poisoned]
@swolchok
Update
e7768b6 
[ghstack-poisoned]
@swolchok
Update
c8e0240 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok mentioned this pull request Feb 7, 2025
Merged
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8316

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e26cdac with merge base c8311e6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
swolchok added a commit that referenced this pull request Feb 7, 2025
@swolchok
Use tensor_shape_to_c_string for error in check_glu_args
56cddf4 
Rolling out for #7902

ghstack-source-id: 2537911
ghstack-comment-id: 2643883485
Pull Request resolved: #8316
@swolchok swolchok added the release notes: devtools Changes to dev tooling, for example the debugger & profiler label Feb 7, 2025
This was referenced Feb 7, 2025
Closed
Closed
@swolchok
Update
1a17c4d 
[ghstack-poisoned]
@swolchok
Update
0767f40 
[ghstack-poisoned]
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Open
Base automatically changed from gh/swolchok/236/head to main February 12, 2025 00:30
@swolchok
Update
4b70787 
[ghstack-poisoned]
@swolchok
Update
e9cda82 
[ghstack-poisoned]
@swolchok
Update
e26cdac 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 13, 2025
@swolchok
Use tensor_shape_to_c_string for error in check_glu_args
9a14af8 
Rolling out for #7902

ghstack-source-id: 1bf9048
ghstack-comment-id: 2643883485
Pull Request resolved: #8316
@swolchok swolchok mentioned this pull request Feb 13, 2025
Merged
@swolchok swolchok merged commit f8e3676 into main Feb 13, 2025
45 of 46 checks passed
@swolchok swolchok deleted the gh/swolchok/237/head branch February 13, 2025 15:54
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
Open
This was referenced Feb 24, 2025
Open
Open
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Use tensor_shape_to_c_string for error in check_glu_args
1d712ec 
Rolling out for #7902

ghstack-source-id: 1bf9048
ghstack-comment-id: 2643883485
Pull Request resolved: pytorch/executorch#8316
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
Use tensor_shape_to_c_string for error in check_glu_args
2e2cf23 
Rolling out for #7902

ghstack-source-id: 24858e6
ghstack-comment-id: 2643883485
Pull Request resolved: pytorch/executorch#8316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: devtools Changes to dev tooling, for example the debugger & profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @manuelcandales @facebook-github-bot