Move ai-edge-model-explorer into devtools/install_requirements.sh#7675
Merged
mergennachin merged 1 commit intomainfrom Jan 16, 2025
Merged
Move ai-edge-model-explorer into devtools/install_requirements.sh#7675mergennachin merged 1 commit intomainfrom
mergennachin merged 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7675
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
3d394ba to
a9e98d4
Compare
digantdesai
approved these changes
Jan 15, 2025
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| # Conflict: this requires numpy<2 whereas ExecuTorch core requires numpy>=2 |
Contributor
There was a problem hiding this comment.
How does this will work, once ET moves to numpy>=2?
Does Google have a plan to upgrade to a newer numpy?
Contributor
Author
There was a problem hiding this comment.
Asked in google-ai-edge/model-explorer#277
Summary: From top-level requirements, move to devtools/install_requirement.sh instead. ai-edge-model-explorer is too new and currently requires numpy<2 which conflicts with our recent upgrade. Let's not take core dependency on this tool yet.
a9e98d4 to
cca4325
Compare
Collaborator
|
FYI: @Erik-Lundell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From top-level requirements, move to devtools/install_requirement.sh instead.
ai-edge-model-explorer is too new and currently requires numpy<2 (https://github.com/google-ai-edge/model-explorer/blob/main/src/server/package/pyproject.toml#L26) which conflicts with our recent upgrade (#7599)
Let's not take core dependency on this tool yet.
Test Plan
python devtools/visualization/visualization_utils_test.py
make sure error is thrown
run
sh devtools/install_requirement.shmake sure the script is successfully run.