Log dtype names on input dtype mismatch#7537
Merged
GregoryComer merged 1 commit intopytorch:mainfrom Jan 15, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7537
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5db5142 with merge base cf8d0cf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
b5dc13e to
fe27795
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
fe27795 to
6f18fd5
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 7, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:825] Input 0 has unexpected scalar type: expected Byte but was Float. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Reviewed By: digantdesai Differential Revision: D67887770 Pulled By: GregoryComer
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 7, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:825] Input 0 has unexpected scalar type: expected Byte but was Float. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Reviewed By: digantdesai Differential Revision: D67887770 Pulled By: GregoryComer
6f18fd5 to
27df369
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 7, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:825] Input 0 has unexpected scalar type: expected Byte but was Float. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:825] Input 0 has unexpected scalar type: expected Byte but was Float. ``` Reviewed By: digantdesai Differential Revision: D67887770 Pulled By: GregoryComer
27df369 to
1264bfb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
SS-JIA
approved these changes
Jan 7, 2025
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 8, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:825] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:825] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Reviewed By: digantdesai, SS-JIA Differential Revision: D67887770 Pulled By: GregoryComer
1264bfb to
d246907
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 8, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` I also locally patched and built the bento kernel with ET_ENABLE_ENUM_STRINGS=0. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected 6 but was 0. ``` Reviewed By: digantdesai, SS-JIA Differential Revision: D67887770 Pulled By: GregoryComer
d246907 to
7b0b127
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 8, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` I also locally patched and built the bento kernel with ET_ENABLE_ENUM_STRINGS=0. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected 6 but was 0. ``` Reviewed By: digantdesai, SS-JIA Differential Revision: D67887770 Pulled By: GregoryComer
7b0b127 to
4563528
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jan 9, 2025
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` I also locally patched and built the bento kernel with ET_ENABLE_ENUM_STRINGS=0. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected 6 but was 0. ``` Reviewed By: digantdesai, SS-JIA Differential Revision: D67887770 Pulled By: GregoryComer
4563528 to
a5900e0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` I also locally patched and built the bento kernel with ET_ENABLE_ENUM_STRINGS=0. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected 6 but was 0. ``` Differential Revision: D67887770 Pulled By: GregoryComer
a5900e0 to
5db5142
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67887770 |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Log dtype names on input dtype mismatch (#7537) Summary: Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is. New Message: ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` Old Message: ``` [method.cpp:826] The 0-th input tensor's scalartype does not meet requirement: found 0 but expected 6 ``` Test Plan: Built executorch bento kernel locally and tested with an incorrect scalar type to view the new error message. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected Float but was Byte. ``` I also locally patched and built the bento kernel with ET_ENABLE_ENUM_STRINGS=0. ``` [method.cpp:834] Input 0 has unexpected scalar type: expected 6 but was 0. ``` Differential Revision: D67887770 Pulled By: GregoryComer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update the error message when input tensor scalar type is incorrect. We've seen this get hit a few times and it should be easier to debug than it is.
New Message:
Old Message:
Differential Revision: D67887770