Improve error messages for tensor size errors#7453
Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom Jan 7, 2025
Merged
Improve error messages for tensor size errors#7453facebook-github-bot merged 1 commit intopytorch:mainfrom
facebook-github-bot merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7453
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4c1443c with merge base 9a884a8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67665846 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 28, 2024
Summary: Print expected and actual tensor sizes when attempting to resize a static tensor. This commonly comes up when a user provides an incorrectly-shaped input tensor and can be confusing. Adding the expected and actual sizes should make this situation more intuitive. This change also includes ET_UNUSED in several places where the variable is used only when logging is enabled, as unused variable warnings cause build failures in some build modes when logging is disabled. Differential Revision: D67665846
329b9ff to
590639c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67665846 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 28, 2024
Summary: Print expected and actual tensor sizes when attempting to resize a static tensor. This commonly comes up when a user provides an incorrectly-shaped input tensor and can be confusing. Adding the expected and actual sizes should make this situation more intuitive. This change also includes ET_UNUSED in several places where the variable is used only when logging is enabled, as unused variable warnings cause build failures in some build modes when logging is disabled. Differential Revision: D67665846
590639c to
a0698bb
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 28, 2024
Summary: Print expected and actual tensor sizes when attempting to resize a static tensor. This commonly comes up when a user provides an incorrectly-shaped input tensor and can be confusing. Adding the expected and actual sizes should make this situation more intuitive. This change also includes ET_UNUSED in several places where the variable is used only when logging is enabled, as unused variable warnings cause build failures in some build modes when logging is disabled. Differential Revision: D67665846
a0698bb to
0ec0af5
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 31, 2024
Summary: Print expected and actual tensor sizes when attempting to resize a static tensor. This commonly comes up when a user provides an incorrectly-shaped input tensor and can be confusing. Adding the expected and actual sizes should make this situation more intuitive. This change also includes ET_UNUSED in several places where the variable is used only when logging is enabled, as unused variable warnings cause build failures in some build modes when logging is disabled. Differential Revision: D67665846
0ec0af5 to
03e02fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67665846 |
Summary: Print expected and actual tensor sizes when attempting to resize a static tensor. This commonly comes up when a user provides an incorrectly-shaped input tensor and can be confusing. Adding the expected and actual sizes should make this situation more intuitive. This change also includes ET_UNUSED in several places where the variable is used only when logging is enabled, as unused variable warnings cause build failures in some build modes when logging is disabled. Differential Revision: D67665846
03e02fe to
4c1443c
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manuelcandales
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Print expected and actual tensor sizes when attempting to resize a static tensor. This commonly comes up when a user provides an incorrectly-shaped input tensor and can be confusing. Adding the expected and actual sizes should make this situation more intuitive.
This change also includes ET_UNUSED in several places where the variable is used only when logging is enabled, as unused variable warnings cause build failures in some build modes when logging is disabled.
Differential Revision: D67665846