Skip to content

Refactor pytest config + add default dump dir option#6637

Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom
Erik-Lundell:refactor-pytest-config
Nov 6, 2024
Merged

Refactor pytest config + add default dump dir option#6637
facebook-github-bot merged 1 commit intopytorch:mainfrom
Erik-Lundell:refactor-pytest-config

Conversation

@Erik-Lundell
Copy link
Collaborator

Introduce arm_test_options Enum to avoid having to remember string names of options.

If pytest is run with --default_dump_path=<some_dir>, .dump* functions will print to a logfile in that dir.
Additionally, pytest will clean up the folder so that only the 10 latest logs are saved.

Change-Id: I932489cf08986ae820e74cd865489ef5561a6444

Introduce arm_test_options Enum to avoid having to
remember string names of options.

If pytest is run with --default_dump_path=<some_dir>, .dump*
functions will print to a logfile in that dir.
Additionally, pytest will clean up the folder so that only
the 10 latest logs are saved.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I932489cf08986ae820e74cd865489ef5561a6444
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6637

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0f667c0 with merge base c045c35 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2024
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Nov 5, 2024
Comment on lines 40 to 41
parser.addoption("--arm_quantize_io", action="store_true")
parser.addoption("--arm_run_corstone300", action="store_true")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop arm_ prefix?

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit c438f8d into pytorch:main Nov 6, 2024
@Erik-Lundell Erik-Lundell deleted the refactor-pytest-config branch November 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants