compiler.h changes for Windows MSVC support#6623
Merged
facebook-github-bot merged 1 commit intomainfrom Nov 5, 2024
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6623
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 0677a48 with merge base 8a4e492 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
Summary: Pull Request resolved: #6623 Differential Revision: D65328573
6b11ec8 to
ea21c7a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
ea21c7a to
19aa228
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
Summary: Pull Request resolved: #6623 Differential Revision: D65328573
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573
19aa228 to
72fbf8b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
72fbf8b to
80b0f91
Compare
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573
80b0f91 to
0f120f4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Differential Revision: D65328573
0f120f4 to
953b1bc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
dbort
approved these changes
Nov 4, 2024
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
953b1bc to
689673c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
689673c to
be2de10
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
be2de10 to
e42c91a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
malfet
reviewed
Nov 4, 2024
| if (a.isInt() && b.isInt()) { | ||
| const int64_t quot = a.toInt() / b.toInt(); | ||
| if (std::signbit(a.toInt()) == std::signbit(b.toInt())) { | ||
| if ((a.toInt() < 0) == (b.toInt() < 0)) { |
Contributor
There was a problem hiding this comment.
This feels unrelated to PR in question, is it?
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
e42c91a to
641c52e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
641c52e to
bb5008b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
bb5008b to
86fb5fb
Compare
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
86fb5fb to
0677a48
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65328573 |
tarun292
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Adding some MSVC (Windows) specific macros to compiler.h to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328573
| // There currently doesn't seem to be a great way to do this in Windows and | ||
| // given that weak linkage is not really critical on Windows, we'll just leave | ||
| // it as a stub. | ||
| #define ET_WEAK |
Contributor
There was a problem hiding this comment.
Hi, we are adding Windows x64 Build Support #6979. I use .\install_requirements.bat --pybind xnnpack to build on windows. And we encountered duplicate symbol problem.
I investigated and found that windows didn't support weak symbol. Do you have some insights how to resolve this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D65328573