Add trunc scalar prim_op#6580
Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom Nov 6, 2024
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6580
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0fe0696 with merge base 17ad8d3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
6fc4982 to
67776fa
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mcr229
approved these changes
Oct 31, 2024
67776fa to
37df95c
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 3, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 3, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
37df95c to
3f9bd10
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 5, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
3f9bd10 to
a23997e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 5, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
a23997e to
f879ba1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 5, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
f879ba1 to
859e530
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 5, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
859e530 to
c78d3c8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
c78d3c8 to
71f5f4f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
71f5f4f to
813da60
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
813da60 to
fab90d1
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 6, 2024
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Test Plan: Added a test for trunc in prim ops tests. Also validated end to end with MSGR ODNC model. Differential Revision: D65057149 Pulled By: GregoryComer
fab90d1 to
8dd9281
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
8dd9281 to
5b592bc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
Summary: Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations. Note that trunc is already supported in export. Reviewed By: mcr229 Differential Revision: D65057149
5b592bc to
0fe0696
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65057149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a primitive op kernel for scalar trunc (double -> int). This corresponds to python math.trunc in the export graph and is used in some torchvision transforms for size calculations.
Note that trunc is already supported in export.
Reviewed By: mcr229
Differential Revision: D65057149