Add default dim_order asserts#4725
Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom Aug 16, 2024
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4725
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 17c9274 with merge base 9a98abb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61311560 |
digantdesai
added a commit
to digantdesai/executorch-1
that referenced
this pull request
Aug 15, 2024
Summary: Pull Request resolved: pytorch#4725 Add a couple of sanity checks to avoid accepting unsupported dim_order * AoT: make sure all the inputs have default dim_order (=contiguous_format) * Runtime: all the incoming etensors have default dim_order (=contiguous_format) Differential Revision: D61311560
6e4a4ff to
20d9fbb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61311560 |
Summary: Pull Request resolved: pytorch#4725 Add a couple of sanity checks to avoid accepting unsupported dim_order * AoT: make sure all the inputs have default dim_order (=contiguous_format) * Runtime: all the incoming etensors have default dim_order (=contiguous_format) Differential Revision: D61311560
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61311560 |
20d9fbb to
17c9274
Compare
mcr229
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a couple of sanity checks to avoid accepting unsupported dim_order
Differential Revision: D61311560