Fix return type mismatch in choose_qparams_tensor_out#4711
Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom Aug 14, 2024
Merged
Conversation
This fix addresses the undefined symbol error for torch::executor::native::choose_qparams_tensor_out when building on native Windows. The root cause is a mismatch between the return types in the function declaration (std::tuple<Tensor &, Tensor &>) and the function definition (std::tuple<Tensor, Tensor>). Additionally, the function definition cannot see the function declaration, so the compiler cannot catch the issue. While the Linux linker seems to handle the return type mismatch, the Windows linker reports an undefined symbol. This fix updates the return type in the function definition to match the function declaration. If possible, it would be beneficial to include the header of the function declaration so that the issue can be caught at compile time.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4711
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f17b11a with merge base 5477369 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
manuelcandales
approved these changes
Aug 14, 2024
Contributor
|
@manuelcandales has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Aug 15, 2024
Differential Revision: D61272239 Pull Request resolved: pytorch#4711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses the undefined symbol error for torch::executor::native::choose_qparams_tensor_out when building on native Windows.
The root cause is a mismatch between the return types in the function declaration (std::tuple<Tensor &, Tensor &>) and the function definition (std::tuple<Tensor, Tensor>). Additionally, the function definition cannot see the function declaration, so the compiler cannot catch the issue. While the Linux linker seems to handle the return type mismatch, the Windows linker reports an undefined symbol.
This fix updates the return type in the function definition to match the function declaration. If possible, it would be beneficial to include the header of the function declaration so that the issue can be caught at compile time.
Fixes #4659