[Android] Rename so file to match soname#3810
Closed
kirklandsign wants to merge 3 commits intopytorch:mainfrom
Closed
[Android] Rename so file to match soname#3810kirklandsign wants to merge 3 commits intopytorch:mainfrom
kirklandsign wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3810
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 17a9436 with merge base 7bcdb0e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shoumikhin
approved these changes
Jun 3, 2024
Contributor
|
@kirklandsign merged this pull request in 2c00ade. |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.2 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Jun 3, 2024
Summary: Pull Request resolved: #3810 Test Plan: Use artifact from https://gha-artifacts.s3.amazonaws.com/pytorch/executorch/9356134478/artifact/executorch-llama.aar to build demo app Reviewed By: shoumikhin Differential Revision: D58100605 Pulled By: kirklandsign fbshipit-source-id: a1febda12a546b7bf53c1059a603fece0e5553c5 (cherry picked from commit 2c00ade)
Collaborator
Cherry picking #3810The cherry pick PR is at #3818 and it is recommended to link a fixnewfeature cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
mcr229
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Rename so file to match soname (#3810) Summary: Pull Request resolved: #3810 Test Plan: Use artifact from https://gha-artifacts.s3.amazonaws.com/pytorch/executorch/9356134478/artifact/executorch-llama.aar to build demo app Reviewed By: shoumikhin Differential Revision: D58100605 Pulled By: kirklandsign fbshipit-source-id: a1febda12a546b7bf53c1059a603fece0e5553c5 (cherry picked from commit 2c00ade) * Need to build aar in release branch as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java layer expects
libexecutorch.so. Fix the name in aar.