Only unset HOME when running cmake as root#3512
Merged
mcr229 merged 1 commit intopytorch:release/0.2from May 21, 2024
Merged
Conversation
This hack is required to work around pytorch/test-infra#5091, which runs some CI jobs as root, which buck2 doesn't like. But we saw in pytorch#3502 that this can break things for some normal users. Reduce the blast radius of this hack, only modifying HOME when actually running as root.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3512
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9904f73 with merge base d3326a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cccclai
approved these changes
May 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hack is required to work around pytorch/test-infra#5091, which runs some CI jobs as root, which buck2 doesn't like.
But we saw in #3502 that this can break things for some normal users.
Reduce the blast radius of this hack, only modifying HOME when actually running as root.
Cherry-pick #3507