Refactor make_boxed_from_unboxed_functor.h#2184
Closed
larryliu0820 wants to merge 2 commits intogh/larryliu0820/18/basefrom
Closed
Refactor make_boxed_from_unboxed_functor.h#2184larryliu0820 wants to merge 2 commits intogh/larryliu0820/18/basefrom
larryliu0820 wants to merge 2 commits intogh/larryliu0820/18/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2184
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New FailuresAs of commit 74142e8 with merge base e2a8f95 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 29, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iseeyuan
requested changes
Mar 2, 2024
Contributor
iseeyuan
left a comment
There was a problem hiding this comment.
Please add summaries to explain why this refactor, and what have been refactored.
Contributor
|
Close stale PR |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 420be27 Pull Request resolved: pytorch/executorch#2184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D54394152