Skip to content

Refactor make_boxed_from_unboxed_functor.h#2184

Closed
larryliu0820 wants to merge 2 commits intogh/larryliu0820/18/basefrom
gh/larryliu0820/18/head
Closed

Refactor make_boxed_from_unboxed_functor.h#2184
larryliu0820 wants to merge 2 commits intogh/larryliu0820/18/basefrom
gh/larryliu0820/18/head

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Feb 29, 2024

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2184

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures

As of commit 74142e8 with merge base e2a8f95 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 29, 2024
larryliu0820 added a commit that referenced this pull request Feb 29, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b1c1598
Pull Request resolved: #2184
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add summaries to explain why this refactor, and what have been refactored.

larryliu0820 added a commit that referenced this pull request Mar 7, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 420be27
Pull Request resolved: #2184
@cccclai
Copy link
Contributor

cccclai commented May 19, 2025

Close stale PR

@cccclai cccclai closed this May 19, 2025
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 420be27
Pull Request resolved: pytorch/executorch#2184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants