[Executorch] Make module constructors uniform across#16122
Merged
kimishpatel merged 1 commit intomainfrom Dec 7, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16122
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Unrelated FailureAs of commit 423a9e4 with merge base 44ae134 ( CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
4eda1bf to
250c3b1
Compare
Pull Request resolved: #15729 Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. ghstack-source-id: 327518046 @exported-using-ghexport Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/)
2864b0f to
423a9e4
Compare
kimishpatel
approved these changes
Dec 7, 2025
This PR needs a
|
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#15729 by @kimishpatel ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/212/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/212/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/211/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/212/orig Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) @diff-train-skip-merge Co-authored-by: Kimish Patel <kimishpatel@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #15729 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/212/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/212/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/211/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/212/orig
Differential Revision: D86120037
@diff-train-skip-merge