Skip to content

Re-land cve security fix#16103

Merged
lucylq merged 1 commit intopytorch:mainfrom
lucylq:export-D88502561
Dec 5, 2025
Merged

Re-land cve security fix#16103
lucylq merged 1 commit intopytorch:mainfrom
lucylq:export-D88502561

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Dec 5, 2025

Summary: Was reverted by D78689027

Differential Revision: D88502561

Summary: Was reverted by D78689027

Differential Revision: D88502561
@lucylq lucylq requested a review from JacobSzwejbka as a code owner December 5, 2025 18:48
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16103

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 235f992 with merge base 4014597 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2025
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Dec 5, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88502561.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq mentioned this pull request Dec 5, 2025
@lucylq lucylq requested a review from psiddh December 5, 2025 18:50
@lucylq lucylq merged commit 42e3222 into pytorch:main Dec 5, 2025
147 of 157 checks passed
@zingo
Copy link
Collaborator

zingo commented Dec 6, 2025

This extra print seem to have broken the Cortex-M size tests :(

https://ossci-raw-job-status.s3.amazonaws.com/log/pytorch/executorch/57296837413

2025-12-05T22:30:33.4891777Z + echo 'size: 135776, threshold: 135768'
2025-12-05T22:30:33.4892092Z size: 135776, threshold: 135768
2025-12-05T22:30:33.4892364Z + [[ 135776 -le 135768 ]]
2025-12-05T22:30:33.4892607Z + echo 'Fail 135776 > 135768'
2025-12-05T22:30:33.4892870Z Fail 135776 > 135768

Im not sure but it might been detected ig the trunk label was set on this PR. Mybe it should be set when the c/c++ code is changed, or maybe the size test could be moved to "pull" ?
If the later is wished for I can try to make a PR?

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
Summary: Was reverted by D78689027

Differential Revision: D88502561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants