Skip to content

Introduce PTEFile class#15800

Merged
meta-codesync[bot] merged 9 commits intogh/lucylq/125/basefrom
gh/lucylq/125/head
Nov 18, 2025
Merged

Introduce PTEFile class#15800
meta-codesync[bot] merged 9 commits intogh/lucylq/125/basefrom
gh/lucylq/125/head

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 13, 2025

Stack from ghstack (oldest at bottom):

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the program definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the program concept.

Now, segment data is included in the PTEFile class.

Differential Revision: D86814175

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15800

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Unrelated Failures

As of commit 6c8e9e4 with merge base b1e3e28 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@lucylq
Copy link
Contributor Author

lucylq commented Nov 14, 2025

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@zingo thanks for the suggestion - could you comment a bit more on what you're looking for?

@zingo
Copy link
Collaborator

zingo commented Nov 14, 2025

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@zingo thanks for the suggestion - could you comment a bit more on what you're looking for?

Im thinking the it might be god to have if you made tools parsing the different files. As Im not writing those kind of tools right now Im not sure its fully applicable but I feel the bpte are sometimes forgotten or need special handling.

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Nov 14, 2025
Pull Request resolved: #15800

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.
ghstack-source-id: 322859321
@exported-using-ghexport

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new PTEFile class to wrap together the components needed for PTE (PyTorch Edge) file serialization and deserialization: the program, mutable data, and named data. This is a breaking API change that updates deserialize_pte_binary() to return a PTEFile instead of a Program.

Key Changes:

  • Introduces PTEFile dataclass to encapsulate Program, mutable data segments, and named data
  • Refactors segment restoration logic by extracting _restore_constant_segment() function
  • Updates deserialize_pte_binary() return type from Program to PTEFile
  • Updates all call sites to access .program property from the returned PTEFile object

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
exir/_serialize/_program.py Core implementation: adds PTEFile class, refactors _restore_constant_segment(), updates _restore_segments() and deserialize_pte_binary() return types to support mutable and named data extraction
exir/_serialize/init.py Exports the new PTEFile class as _PTEFile
exir/_serialize/test/test_program.py Updates tests to handle PTEFile return type, adds helper methods _check_named_data_entries() and _check_named_data_store_output() for validation, adds roundtrip serialization tests
exir/emit/test/test_emit.py Updates test to access .program from deserialized PTEFile
examples/qualcomm/oss_scripts/llama/decoder_utils.py Updates to access .program from deserialize_pte_binary() result
codegen/tools/gen_ops_def.py Updates to access .program from deserialize_pte_binary() result
backends/qualcomm/utils/utils.py Updates to access .program from deserialize_pte_binary() result
backends/cadence/runtime/runtime.py Updates to access .program from nested deserialize_pte_binary() result

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Nov 17, 2025
Pull Request resolved: #15800

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.
ghstack-source-id: 323865077
@exported-using-ghexport

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Nov 17, 2025
Pull Request resolved: #15800

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.
ghstack-source-id: 323871061
@exported-using-ghexport

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Nov 17, 2025
Pull Request resolved: #15800

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the `program` definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the `program` concept.

Now, segment data is included in the PTEFile class.
ghstack-source-id: 323871061
@exported-using-ghexport

Differential Revision: [D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
@meta-codesync meta-codesync bot merged commit e6c3a01 into gh/lucylq/125/base Nov 18, 2025
167 of 180 checks passed
@meta-codesync meta-codesync bot deleted the gh/lucylq/125/head branch November 18, 2025 03:09
lucylq added a commit that referenced this pull request Nov 18, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #15800 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/125/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/125/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/125/orig
Differential Revision:
[D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
@diff-train-skip-merge

Co-authored-by: lucylq <lfq@meta.com>
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#15800 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/125/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/125/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/125/orig
Differential Revision:
[D86814175](https://our.internmc.facebook.com/intern/diff/D86814175/)
@diff-train-skip-merge

Co-authored-by: lucylq <lfq@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants