[Executorch] Make module constructors uniform across#15655
[Executorch] Make module constructors uniform across#15655kimishpatel wants to merge 1 commit intogh/kimishpatel/206/basefrom
Conversation
Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15655
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Cancelled Jobs, 4 Unrelated FailuresAs of commit 9deaf74 with merge base 15a0fcd ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
| explicit Module( | ||
| const std::string& file_path, | ||
| const LoadMode load_mode = LoadMode::File, | ||
| std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr, |
There was a problem hiding this comment.
nit: update the doc comments too?
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.
Differential Revision: D86120037