Arm backend: support torch.sum.default#15380
Merged
zingo merged 4 commits intopytorch:mainfrom Oct 30, 2025
Merged
Conversation
When sum is called without arguments, it is traced as sum.default rather than sum.dim_IntList, which 1) is lowered to edge with dims=[] instead of None, and 2) is not annotated in the quantizer. This commit fixes those issues and adds tests. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ic9ae84c62a713f136de7bff2594bacbdfc759995
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15380
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 295e014 with merge base ed91b6a ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
@Erik-Lundell this has a tests fail in test-arm-backed (test_model_ethos-u55) something to fix or retrigger? |
Collaborator
|
This will probably go awaiw with a rebase trunk / test-mcu-models (cmake) |
zingo
approved these changes
Oct 30, 2025
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
When sum is called without arguments, it is traced as sum.default rather than sum.dim_IntList, which 1) is lowered to edge with dims=[] instead of None, and 2) is not annotated in the quantizer. This commit fixes those issues and adds tests. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sum is called without arguments,
it is traced as sum.default rather than sum.dim_IntList, which 1) is lowered to edge with dims=[] instead of None, and 2) is not annotated in the quantizer.
This commit fixes those issues and adds tests.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai