Fix pip install . -e when buck2 is not installed#11842
Merged
mergennachin merged 2 commits intomainfrom Jun 26, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11842
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 1 Pending, 1 Unrelated FailureAs of commit 842cf09 with merge base ba9254a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jathu
reviewed
Jun 22, 2025
jathu
approved these changes
Jun 23, 2025
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
If the installation goes through regular './install_executorch.sh' path, it sets the -DBUCK2 cmake config, but if you directly call `pip install .` it doesn't resolve buck dependency. Test Plan: Run - `./install_requirement.sh` and `pip install . --no-build-isolation -v` - `./install_requirement.sh` and `pip install -e . --no-build-isolation -v` - ./install_executorch.sh cc @larryliu0820 @jathu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the installation goes through regular './install_executorch.sh' path, it sets the -DBUCK2 cmake config, but if you directly call
pip install .itdoesn't resolve buck dependency.
Test Plan:
Run
./install_requirement.shandpip install . --no-build-isolation -v./install_requirement.shandpip install -e . --no-build-isolation -vcc @larryliu0820 @jathu