Merged
Conversation
Member
|
Could you add a small test for this? |
Contributor
Author
|
@filmor sure! Do I need to checkout & install an alternative mono binary for the test or could I just point it to system mono? |
Member
|
Just point at the system mono, I just want to be sure that the call itself succeeds. |
Contributor
Author
|
@filmor ok will do. I am setting up a docker image to see where the system mono usually is. I added another mono API |
Contributor
Author
|
@filmor tests added |
Contributor
Author
|
@filmor the test failures appear to be unrelated. Do I need to edit any changelog? |
Member
|
I fixed the unrelated test failures. I don't keep a separate Changelog from the autogenerated ones from Github, I think that's fine for a repo of this size :) Thank you for your contribution, I'll cut a release this week. |
koubaa
added a commit
to ansys/ansys-pythonnet
that referenced
this pull request
Jan 4, 2023
This allows pythonnet to work in the version of mono we ship with the unified install I made the change in clr_loader in this PR: pythonnet/clr-loader#43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27