Skip to content

mypy_primer: mention if output is truncated #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Mar 21, 2022
Merged

mypy_primer: mention if output is truncated #7525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5be781
mypy_primer: mention if output is truncated
Mar 21, 2022
b9f59ef
fix indent
Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/mypy_primer_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ jobs:
fs.writeFileSync("diff.zip", Buffer.from(download.data));

- run: unzip diff.zip
# 30000 bytes is about 300 lines, posting comment fails if too long
- run: |
cat diff_*.txt | head -c 30000 | tee fulldiff.txt
cat diff_*.txt | tee fulldiff.txt

- name: Post comment
id: post-comment
Expand All @@ -49,7 +48,11 @@ jobs:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const fs = require('fs')
const data = fs.readFileSync('fulldiff.txt', { encoding: 'utf8' })
let data = fs.readFileSync('fulldiff.txt', { encoding: 'utf8' })
// posting comment fails if too long, so truncate
if (data.length > 30000) {
data = data.substring(0, 30000) + `\n\n... (truncated ${diff.length - 30000} chars) ...\n`
}

let body
if (data.trim()) {
Expand Down