Skip to content

change getattr stubs to better type the default argument and return type #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 7 commits into from
May 21, 2021
Merged

change getattr stubs to better type the default argument and return type #5516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95eb27d
change getattr stubs to better type the default argument and return type
neilvyas May 21, 2021
fcda6b2
add overloads for 2/3 arg forms
neilvyas May 21, 2021
84e4bb9
define the two-arg form overload first
neilvyas May 21, 2021
e5e3bce
Update stdlib/builtins.pyi
hauntsaninja May 21, 2021
0c6b008
add an extra overload for the 'None' case to provide a better message
neilvyas May 21, 2021
381165c
Update stdlib/@python2/__builtin__.pyi
hauntsaninja May 21, 2021
4108554
Update stdlib/@python2/builtins.pyi
hauntsaninja May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/@python2/__builtin__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ def filter(__function: None, __iterable: Iterable[Optional[_T]]) -> List[_T]: ..
@overload
def filter(__function: Callable[[_T], Any], __iterable: Iterable[_T]) -> List[_T]: ...
def format(__value: object, __format_spec: str = ...) -> str: ... # TODO unicode
def getattr(__o: Any, name: Text, __default: Any = ...) -> Any: ...
def getattr(__o: Any, name: Text, __default: _T = ...) -> Union[Any, _T]: ...
def globals() -> Dict[str, Any]: ...
def hasattr(__obj: Any, __name: Text) -> bool: ...
def hash(__obj: object) -> int: ...
Expand Down
2 changes: 1 addition & 1 deletion stdlib/@python2/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ def filter(__function: None, __iterable: Iterable[Optional[_T]]) -> List[_T]: ..
@overload
def filter(__function: Callable[[_T], Any], __iterable: Iterable[_T]) -> List[_T]: ...
def format(__value: object, __format_spec: str = ...) -> str: ... # TODO unicode
def getattr(__o: Any, name: Text, __default: Any = ...) -> Any: ...
def getattr(__o: Any, name: Text, __default: _T = ...) -> Union[Any, _T]: ...
def globals() -> Dict[str, Any]: ...
def hasattr(__obj: Any, __name: Text) -> bool: ...
def hash(__obj: object) -> int: ...
Expand Down
2 changes: 1 addition & 1 deletion stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ class filter(Iterator[_T], Generic[_T]):
def __next__(self) -> _T: ...

def format(__value: object, __format_spec: str = ...) -> str: ... # TODO unicode
def getattr(__o: Any, name: str, __default: Any = ...) -> Any: ...
def getattr(__o: Any, name: str, __default: _T = ...) -> Union[Any, _T]: ...
def globals() -> Dict[str, Any]: ...
def hasattr(__obj: Any, __name: str) -> bool: ...
def hash(__obj: object) -> int: ...
Expand Down