Skip to content

fix: correct headers= kwarg in HTTP[S]Connection #12704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 5 commits into from
Oct 1, 2024
Merged

fix: correct headers= kwarg in HTTP[S]Connection #12704

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12bcba3
fix: correct headers= kwarg in HTTP[S]Connection
dimaqq Sep 30, 2024
c553424
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 30, 2024
fef880c
fix: missing self in protocol method
dimaqq Sep 30, 2024
f3cd67c
Merge commit 'c553424c9'
dimaqq Sep 30, 2024
5fc861a
use `str` instead of a Protocol
dimaqq Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stdlib/http/client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ __all__ = [
_DataType: TypeAlias = SupportsRead[bytes] | Iterable[ReadableBuffer] | ReadableBuffer
_T = TypeVar("_T")
_MessageT = TypeVar("_MessageT", bound=email.message.Message)
_HeaderValue: TypeAlias = ReadableBuffer | str | int

HTTP_PORT: int
HTTPS_PORT: int
Expand Down Expand Up @@ -167,7 +168,7 @@ class HTTPConnection:
method: str,
url: str,
body: _DataType | str | None = None,
headers: Mapping[str, str] = {},
headers: Mapping[str, _HeaderValue] = {},
*,
encode_chunked: bool = False,
) -> None: ...
Expand All @@ -180,7 +181,7 @@ class HTTPConnection:
def connect(self) -> None: ...
def close(self) -> None: ...
def putrequest(self, method: str, url: str, skip_host: bool = False, skip_accept_encoding: bool = False) -> None: ...
def putheader(self, header: str | bytes, *argument: str | bytes) -> None: ...
def putheader(self, header: str | bytes, *values: _HeaderValue) -> None: ...
def endheaders(self, message_body: _DataType | None = None, *, encode_chunked: bool = False) -> None: ...
def send(self, data: _DataType | str) -> None: ...

Expand Down