Skip to content

Bump pyright to v1.1.360#11810

Merged
srittau merged 5 commits intopython:mainfrom
AlexWaygood:many-pyright-ignores
Apr 24, 2024
Merged

Bump pyright to v1.1.360#11810
srittau merged 5 commits intopython:mainfrom
AlexWaygood:many-pyright-ignores

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 22, 2024

Closes #11780

@AlexWaygood AlexWaygood changed the title many pyright ignores Bump pyright to v1.1.359 Apr 22, 2024
@AlexWaygood AlexWaygood mentioned this pull request Apr 22, 2024
Closed
1 task
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Apr 22, 2024

Well, I still don't think this is exactly a pretty solution 😄 But it's ready for review -- and after the next pyright release, we'd be able to change them all to pyright: ignore[reportInvalidTypeVarUse] following the changes Eric just made in microsoft/pyright@f22576f.

@AlexWaygood AlexWaygood marked this pull request as ready for review April 22, 2024 17:03
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Apr 23, 2024 •
edited
Loading

I'll wait until the next pyright release (which I think will be tonight or tomorrow, according to the usual schedule) before landing this, since the next pyright release will presumably include microsoft/pyright@f22576f in it, and that will mean we can update all the ignores to reportInvalidTypeVarUse.

@AlexWaygood AlexWaygood changed the title Bump pyright to v1.1.359 Bump pyright to v1.1.360 Apr 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Apr 24, 2024

Ugh, what on earth is going on with third-party stubtest and GitHub Actions right now?

@srittau
Copy link
Collaborator

srittau commented Apr 24, 2024

Stubtest failures are unrelated.

@srittau srittau merged commit d0f2be9 into python:main Apr 24, 2024
@AlexWaygood AlexWaygood deleted the many-pyright-ignores branch April 24, 2024 12:10
@maxfischer2781 maxfischer2781 mentioned this pull request May 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood @srittau