Skip to content

Consistently reference theme_root_icon #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 6 commits into from
Jan 12, 2024
Merged

Consistently reference theme_root_icon #163

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
137681f
Update layout.html
mbudisic Jan 9, 2024
099019d
theme.conf root_icon and root_icon_alt_text variables interpolated in…
mbudisic Jan 10, 2024
47684e2
Apply suggestions from code review
mbudisic Jan 10, 2024
0667e59
Options made adjacent in theme.conf for readability
mbudisic Jan 12, 2024
5422219
Tildes instead of plus to concatenate strings in the new changes
mbudisic Jan 12, 2024
23abd2a
Replaced + with ~ string concatenation everywhere in layout.html
mbudisic Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python_docs_theme/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ <h3>{{ _('Navigation') }}</h3>
</li>
{%- endfor %}
{%- block rootrellink %}
<li><img src="{{ pathto('_static/py.svg', 1) }}" alt="python logo" style="vertical-align: middle; margin-top: -1px"/></li>
<li><img src="{{ pathto('_static/' + theme_root_icon, 1) }}" alt="{{theme_root_icon_alt_text}}" style="vertical-align: middle; margin-top: -1px"/></li>
<li><a href="{{theme_root_url}}">{{theme_root_name}}</a>{{ reldelim1 }}</li>
<li class="switchers">
<div class="language_switcher_placeholder"></div>
Expand Down Expand Up @@ -100,7 +100,7 @@ <h3>{{ _('Navigation') }}</h3>
</label>
<span class="nav-items-wrapper">
<a href="{{ theme_root_url }}" class="nav-logo">
<img src="{{ pathto('_static/py.svg', 1) }}" alt="Logo"/>
<img src="{{ pathto('_static/' + theme_root_icon, 1) }}" alt="{{theme_root_icon_alt_text}}"/>
</a>
<span class="version_switcher_placeholder"></span>
{%- if pagename != "search" and builder != "singlehtml" %}
Expand Down
1 change: 1 addition & 0 deletions python_docs_theme/theme.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ root_name = Python
root_url = https://www.python.org/
root_icon = py.svg
root_include_title = True
root_icon_alt_text = Python logo
copyright_url =