Remove __eq__ and __ne__ overrides for dataclasses and attrs#8642
Merged
JukkaL merged 1 commit intopython:masterfrom Apr 8, 2020
tkukushkin:fix-8638
Merged
Remove __eq__ and __ne__ overrides for dataclasses and attrs#8642JukkaL merged 1 commit intopython:masterfrom tkukushkin:fix-8638
JukkaL merged 1 commit intopython:masterfrom
tkukushkin:fix-8638
Conversation
JukkaL
approved these changes
Apr 8, 2020
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for the PR! Creating __eq__ and __ne__ methods seems to serve no useful purpose.
Collaborator
|
The Travis failure is a flake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8638.