Restrict types for stubs in itertools#358
Merged
JukkaL merged 4 commits intopython:masterfrom Aug 14, 2014
Merged
Conversation
Contributor
Author
|
Good Catch This is the kind of situation dependent types where would be particularly useful. It might be better to implement instead separate product2, product3, product4, ... and leave itertool's product with a more general type signature. For now I'm going to update the PR with Iterator[Sequence[T]]. |
Closed
Collaborator
|
Thanks, looks good now! We can iterate on the signatures in the future if the current ones seem too restrictive in practice. |
JukkaL
added a commit
that referenced
this pull request
Aug 14, 2014
Restrict types for stubs in itertools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can use Union type to model Maybes and Products.