Allow isinstance/issubclass with nested tuples#2995
Merged
JukkaL merged 4 commits intopython:masterfrom Mar 18, 2017
Merged
Conversation
Member
|
Can you add a unit test please? |
JukkaL
reviewed
Mar 18, 2017
| if isinstance(x, (str, (int, tuple))): | ||
| x[1] # E: Value of type "Union[int, str, tuple]" is not indexable | ||
| else: | ||
| x[1] |
| x[1] # E: Value of type "Union[int, str, tuple]" is not indexable | ||
| else: | ||
| x[1] | ||
| if isinstance(x, (str, (list,))): |
Collaborator
There was a problem hiding this comment.
Add reveal_type(x) before the if statement and within the if body.
Collaborator
|
Thanks, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2994
Useless without python/typeshed#998 (because parser will just choke on the nested tuples anyway). But since there are no tests for nested tuples, this PR is not strictly blocked by that other one.