Updates error examples in Common Issues page for Issue #2393#20362
Open
jbiersdo wants to merge 2 commits intopython:masterfrom
Open
Updates error examples in Common Issues page for Issue #2393#20362jbiersdo wants to merge 2 commits intopython:masterfrom
jbiersdo wants to merge 2 commits intopython:masterfrom
Conversation
wyattscarpenter
approved these changes
Dec 5, 2025
Contributor
wyattscarpenter
left a comment
There was a problem hiding this comment.
I'm taking it on faith that these are the correct error messages; given that, I think it's a good change.
I think it's slightly wrong to say "Fixes issue blah" for this because this is only a partial fix. But that's fine, since this won't close that issue.
| Types of empty collections | ||
| -------------------------- | ||
|
|
||
| Without the annotation mypy can't always figure out the |
Contributor
There was a problem hiding this comment.
Linguistically this has to be rephrased or go back below the other part ("what is 'the annotation'?", thinks the reader of this sentence. "What is a?")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #2393
Updated generic error statements within the single Common Issues page with actual error responses when running examples.
Tried to incorporate the comments from the PR #3404 as well as the PR #7706. Attempting to take this in smaller chunks and submit multiple PRs.
No test needed as this was a documentation only update.