Skip to content

Conversation

@18z
Copy link
Contributor

@18z 18z commented Jun 21, 2017

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link

@18z, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @asvetlov to be potential reviewers.

@18z 18z changed the title Fix trivial typo in idlelib/config.py Fix trivial typo in idlelib/config.py #2309 Jun 21, 2017
@18z
Copy link
Contributor Author

18z commented Jun 21, 2017

@the-knights-who-say-ni Sorry about this. I signed the agreement and fixed the github name.
This is my first PR to cpython. If anything else is missing, please guide me through. : )

@18z 18z changed the title Fix trivial typo in idlelib/config.py #2309 Fix trivial typo in idlelib/config.py Jun 21, 2017
@18z 18z changed the title Fix trivial typo in idlelib/config.py Fix trivial typo in idlelib/config.py (GH-2309) Jun 21, 2017
@mlouielu
Copy link
Contributor

@18z Hi, the CLA signed need to removed by member then it will check it again. otherwise the changed LGTM.

@18z
Copy link
Contributor Author

18z commented Jun 21, 2017

@mlouielu thanks : )

@Mariatta
Copy link
Member

@18z Can you create an account in bugs.python.org, and in that account, add your GitHub username. See this example of where to set your GitHub username. Thanks.

@18z
Copy link
Contributor Author

18z commented Jun 21, 2017

@Mariatta I added my github username in my bugs.python.org account. Thanks. : )

@Mariatta
Copy link
Member

Ah I see. Is your b.p.o username KunYuChen? In there it KunYuChen is set as the GitHub username, not 18z.

@18z
Copy link
Contributor Author

18z commented Jun 21, 2017

Yes, my b.p.o username is KunYuChen.
I set KunYuChen as the Github username, not 18z. Should I change it to 18z?

@mlouielu
Copy link
Contributor

@18z You should used 18z on bugs.python.org, since this is your GitHub username (not the nickname) I think.

@Mariatta
Copy link
Member

Since you created this PR using GitHub username 18z, then in your b.p.o account 18z should be listed as your GitHub username. That's the only way the bot can check that KunYuChen in b.p.o is the same person as 18z on GitHub.
Hope this makes sense.
Alternatively, if you own the GitHub account KunYuChen, then you can keep the current setting, but recreate this PR as using that account.

@18z
Copy link
Contributor Author

18z commented Jun 21, 2017

@Mariatta I changed it to 18z. : )

@Mariatta Mariatta merged commit f3e8209 into python:master Jun 21, 2017
@Mariatta
Copy link
Member

Great, thanks @18z and congrats on your first contribution to CPython 🎉

Can you please backport this to the 3.6 branch? You can use cherry_picker.py
or manually using git cherry-pick -x <hash> to the 3.6 branch.

The hash to be cherry-picked is f3e8209152dffd201620c5b5936946a9250ac359.
Thanks.

@18z
Copy link
Contributor Author

18z commented Jun 21, 2017

@Mariatta Sure, I'll do that. Thanks for your guidance. : )
@mlouielu Thanks again. : )

@Mariatta
Copy link
Member

Thanks @18z and @mlouielu

@terryjreedy
Copy link
Member

Mariatta, please nosy me (or add me as a reviewer, even though a 2nd review is not needed) on anything involving idlelib so I can make sure the backport happens.

terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Jun 22, 2017
Comceptually -> Conceptually
(cherry picked from commit f3e8209)
@bedevere-bot
Copy link

GH-2321 is a backport of this pull request to the 3.6 branch.

terryjreedy added a commit that referenced this pull request Jun 22, 2017
Comceptually -> Conceptually
(cherry picked from commit f3e8209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants