-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Fix trivial typo in idlelib/config.py (GH-2309) #2309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@18z, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @asvetlov to be potential reviewers. |
|
@the-knights-who-say-ni Sorry about this. I signed the agreement and fixed the github name. |
|
@18z Hi, the CLA signed need to removed by member then it will check it again. otherwise the changed LGTM. |
|
@mlouielu thanks : ) |
|
@Mariatta I added my github username in my bugs.python.org account. Thanks. : ) |
|
Ah I see. Is your b.p.o username KunYuChen? In there it KunYuChen is set as the GitHub username, not 18z. |
|
Yes, my b.p.o username is KunYuChen. |
|
@18z You should used |
|
Since you created this PR using GitHub username |
|
@Mariatta I changed it to 18z. : ) |
|
Great, thanks @18z and congrats on your first contribution to CPython 🎉 Can you please backport this to the 3.6 branch? You can use cherry_picker.py The hash to be cherry-picked is |
|
Mariatta, please nosy me (or add me as a reviewer, even though a 2nd review is not needed) on anything involving idlelib so I can make sure the backport happens. |
Comceptually -> Conceptually (cherry picked from commit f3e8209)
|
GH-2321 is a backport of this pull request to the 3.6 branch. |
No description provided.