Skip to content

gh-143507: Fix test in test_urllib2net #143506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuhu2195 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-143507: Fix test in test_urllib2net #143506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ab8c95
typo fix in test_urllib2net
zuhu2195 Jan 7, 2026
82555d6
Merge pull request #1 from zuhu2195/typofix-urllib2net
zuhu2195 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/test/test_urllib2net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def test_ftp_basic(self):
with socket_helper.transient_internet(self.FTP_HOST, timeout=None):
u = _urlopen_with_retry(self.FTP_HOST)
self.addCleanup(u.close)
self.assertIsNone(u.fp.fp.raw._sock.gettimeout())
self.assertIsNone(u.fp.raw._sock.gettimeout())

def test_ftp_default_timeout(self):
self.assertIsNone(socket.getdefaulttimeout())
Expand All @@ -352,7 +352,7 @@ def test_ftp_default_timeout(self):
self.addCleanup(u.close)
finally:
socket.setdefaulttimeout(None)
self.assertEqual(u.fp.fp.raw._sock.gettimeout(), 60)
self.assertEqual(u.fp.raw._sock.gettimeout(), 60)

@support.requires_resource('walltime')
def test_ftp_no_timeout(self):
Expand All @@ -364,14 +364,14 @@ def test_ftp_no_timeout(self):
self.addCleanup(u.close)
finally:
socket.setdefaulttimeout(None)
self.assertIsNone(u.fp.fp.raw._sock.gettimeout())
self.assertIsNone(u.fp.raw._sock.gettimeout())

@support.requires_resource('walltime')
def test_ftp_timeout(self):
with socket_helper.transient_internet(self.FTP_HOST):
u = _urlopen_with_retry(self.FTP_HOST, timeout=60)
self.addCleanup(u.close)
self.assertEqual(u.fp.fp.raw._sock.gettimeout(), 60)
self.assertEqual(u.fp.raw._sock.gettimeout(), 60)


if __name__ == "__main__":
Expand Down
Loading