Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617)#12159
Merged
vstinner merged 4 commits intopython:masterfrom Mar 4, 2019
vstinner:revert_pending_call
Merged
Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617)#12159vstinner merged 4 commits intopython:masterfrom vstinner:revert_pending_call
vstinner merged 4 commits intopython:masterfrom
vstinner:revert_pending_call
Conversation
Member
Author
|
The world hates me: I wrote this PR to fix https://bugs.python.org/issue36114 race condition, but test__xxsubinterpreters failed on AppVeyor :-( https://ci.appveyor.com/project/python/cpython/builds/22802115 |
Member
Author
|
My intent is to revert the commit ef4ac96, but sadly I had to also revert 3 commits written by Eric Snow which are based on this commit :-( I would prefer to revert a single commit, but I had to revert 4 commits :-( |
Member
Author
|
This PR reverts the commit ef4ac96 because it introduced multiple regressions:
|
Member
Author
|
I tested manually this PR and I confirm that it fix https://bugs.python.org/issue36114 I stressed my FreeBSD 12 VM with test_multiprocessing_spawn:
|
This was referenced Mar 15, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33608