Skip to content

gh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 #104556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
May 16, 2023
Merged

gh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 #104556

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c3401
Fix isinstance() and issubclass() for runtime-checkable protocols tha…
AlexWaygood May 16, 2023
6d3c19a
all type variables are now named T
AlexWaygood May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3134,6 +3134,24 @@ def bar(self, x: str) -> str:

self.assertIsInstance(Test(), PSub)

def test_pep695_generic_protocol_callable_members(self):
@runtime_checkable
class Foo[T_co](Protocol):
Copy link
Member

@JelleZijlstra JelleZijlstra May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is a T_contra :)

Copy link
Member Author

@AlexWaygood AlexWaygood May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed my mind, now I hate Hungarian notation

def meth(self, x: T_co) -> None: ...

class Bar[T_co]:
def meth(self, x: T_co) -> None: ...

self.assertIsInstance(Bar(), Foo)
self.assertIsSubclass(Bar, Foo)

@runtime_checkable
class SupportsTrunc[T_co](Protocol):
def __trunc__(self) -> T_co: ...

self.assertIsInstance(0.0, SupportsTrunc)
self.assertIsSubclass(float, SupportsTrunc)

def test_init_called(self):
T = TypeVar('T')

Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1663,7 +1663,7 @@ class _TypingEllipsis:
_TYPING_INTERNALS = frozenset({
'__parameters__', '__orig_bases__', '__orig_class__',
'_is_protocol', '_is_runtime_protocol', '__protocol_attrs__',
'__callable_proto_members_only__',
'__callable_proto_members_only__', '__type_params__',
})

_SPECIAL_NAMES = frozenset({
Expand Down