Skip to content

docs(bootstrapper): fix docstrings and add test for write-error logging#1258

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
dhellmann:docstring-fixes-bootstrapper-performance
Jul 19, 2026
Merged

docs(bootstrapper): fix docstrings and add test for write-error logging#1258
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
dhellmann:docstring-fixes-bootstrapper-performance

Conversation

@dhellmann

@dhellmann dhellmann commented Jul 17, 2026

Copy link
Copy Markdown
Member

This PR has a few changes from Claude's review feedback on #1249

  • Correct add_to_build_order docstring: build-order data is now buffered and written once in finalize(), not on each call
  • Update finalize() docstring to note that background I/O errors are logged but not raised
  • Add comment to __exit__ explaining pending writes are intentionally abandoned on error exit
  • Add "Must only be called from the main thread" note to _write_graph_async docstring
  • Add comment to test_record_stack_state_throttled_when_called_rapidly warning about st_mtime filesystem-resolution dependency
  • Add test_check_write_error_logs_on_failure to verify that failed background write futures are logged rather than raised

- Correct `add_to_build_order` docstring: build-order data is now
  buffered and written once in `finalize()`, not on each call
- Update `finalize()` docstring to note that background I/O errors
  are logged but not raised
- Add comment to `__exit__` explaining pending writes are intentionally
  abandoned on error exit
- Add "Must only be called from the main thread" note to
  `_write_graph_async` docstring
- Add comment to `test_record_stack_state_throttled_when_called_rapidly`
  warning about st_mtime filesystem-resolution dependency
- Add `test_check_write_error_logs_on_failure` to verify that failed
  background write futures are logged rather than raised

Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
dhellmann requested a review from a team as a code owner July 17, 2026 20:14
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dhellmann, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c9fbfc00-ddc6-4202-b1df-67dcfdef9f50

📥 Commits

Reviewing files that changed from the base of the PR and between 4c18163 and 12315ee.

📒 Files selected for processing (2)
  • src/fromager/bootstrapper/_bootstrapper.py
  • tests/test_bootstrapper.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Jul 17, 2026

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rd4398

rd4398 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@mergify rebase

@mergify
mergify Bot merged commit 6e4e93a into python-wheel-build:main Jul 19, 2026
39 checks passed
@mergify

mergify Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify

mergify Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • -closed [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants