Switch from PurePath#as_uri to PurePath#joinpath for our test that PurePath methods get inherited#3249
Conversation
`as_uri` is deprecated in `PurePath`. This commit also introduces a test to ensure users have a workaround that is not deprecated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
================================================
Coverage 100.00000% 100.00000%
================================================
Files 122 124 +2
Lines 18757 19005 +248
Branches 1269 1295 +26
================================================
+ Hits 18757 19005 +248
🚀 New features to boost your workflow:
|
|
IMO we should define a sync and then I think the test change is just to find a different |
|
I wasn't too sure about doing that because there's no fundamental reason that has to be on And users can do |
|
IMO "maintaining 1:1 compatibility with existing code" is enough reason in this case, and right now unblocking CI feels more urgent than answering those other API design questions 😅 (but for completeness: I'd like |
as_uriis deprecated inPurePath. This commit also introduces a test to ensure users have a workaround that is not deprecated.Failing test run: https://github.com/python-trio/trio/actions/runs/14393482504/job/40364976912