Remove hardcoded length in TLSPrefixedArray#129
Open
ashfall wants to merge 2 commits intopython-tls:masterfrom
Open
Remove hardcoded length in TLSPrefixedArray#129ashfall wants to merge 2 commits intopython-tls:masterfrom
ashfall wants to merge 2 commits intopython-tls:masterfrom
Conversation
a0b9365 to
5e014bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 1545 1545
Branches 58 58
=====================================
Hits 1545 1545 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test makes the whole test suite extremely slow, but it was the only test case that reliably failed before my change and passed after. Since the default length is UBInt16, we need something > 2 ** 16 to catch this bug correctly. Everything else either fails with a generic AssertionError on parsing bad values before this bug, or passes. Thoughts?