Filesize simplification

[bbolli]

Changes proposed in this pull request:

• better test coverage filesize.py
• code simplification

[codecov-commenter]

Codecov Report

Merging #76 (70fc85d) into main (60e3b47) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   99.06%   99.05%   -0.01%     
==========================================
  Files           9        9              
  Lines         745      742       -3     
==========================================
- Hits          738      735       -3     
  Misses          7        7              

Flag	Coverage Δ
macos-latest	97.43% <100.00%> (-0.02%)	⬇️
ubuntu-latest	97.43% <100.00%> (-0.02%)	⬇️
windows-latest	95.95% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/humanize/filesize.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[hugovk]

Thanks for the PR!

Do you know why the type checking fails?

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

src/humanize/filesize.py:80: error: Returning Any from function declared to return "str"  [no-any-return]
Found 1 error in 1 file (checked 11 source files)

[bbolli]

Do you know why the type checking fails?

Not really... My local mypy installation (v0.991) does not report any type violations in src/humanize.

[hugovk]

Hmm, the same version is used by the CI:

humanize/.pre-commit-config.yaml

Lines 61 to 66 in 60e3b47

	- repo: https://github.com/pre-commit/mirrors-mypy
	rev: v0.991
	hooks:
	- id: mypy
	additional_dependencies: [pytest, types-freezegun, types-setuptools]
	args: [--strict]

Also with the --strict option.

[hugovk]

Updated to make mypy happy.

The more type-safe way is:

ret = format % (base * bytes_ / unit) + s
assert isinstance(ret, str)
return ret

But this shorter version is good enough for here. Thanks @AlexWaygood for the tips!

[hugovk]

• better test coverage filesize.py

Well, 100% to 100% is no change, and ironically by reducing the total covered lines, it's slightly decreased the total coverage percentage 🙃

• code simplification

but this is appreciated :)

Thank you!