Skip to content
This repository was archived by the owner on Jun 22, 2025. It is now read-only.

Fixed Tests#632

Closed
doug-benn wants to merge 46 commits intopython-eel:masterfrom
doug-benn:Windows-Tests
Closed

Fixed Tests#632
doug-benn wants to merge 46 commits intopython-eel:masterfrom
doug-benn:Windows-Tests

Conversation

@doug-benn
Copy link
Contributor

I have fixed tests, is it pretty... no but they do run, I'm sure there are improvement that could be made!

Sorry for the number of commits and the bad names, I was just testing using the GitHub actions, but the actually changes are small ish.

Thanks

  • Doug

@samuelhwilliams
Copy link
Collaborator

samuelhwilliams commented Dec 9, 2022

Amazing work - the tests do indeed all seem to run and pass which is more than we've had for a long time 🎉

I do think we need to revisit some of this code and clean it up though. I'm particularly not fond of vendoring the binaries and would like to find a solution that doesn't require us to do that. 🤔

Could you squash the commits down into either: a set of logical separate commits, or just a single commit if there's not a sensible separation between them?

Webdriver_manager added to install chrome driver on Windows
Testing on github actions

I broke Linux tests and fixed them again
Python 3.6 has an issue with subprocess

Cleaning up comments and mess

Setting branch in Test.yml
@doug-benn
Copy link
Contributor Author

Hello,

Yes sorry for the mess, I should have fixed it!

The code is definitely a mess and very "hacky". Do you have any suggestion for testing without the binary? I'm not sure how else tests could be done on Eel

Thank you

  • Doug

@doug-benn doug-benn reopened this Dec 9, 2022
@doug-benn
Copy link
Contributor Author

What a mess! Sorry! I'm not even sure if I've done it or not? If it's no good I will make a new branch and start new PR

@doug-benn doug-benn mentioned this pull request Dec 10, 2022
@doug-benn doug-benn closed this Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants