Change math.py to numpydoc style#211
Merged
bnavigator merged 1 commit intopython-control:masterfrom Jan 7, 2024
Merged
Conversation
10 tasks
093d8ff to
48bca92
Compare
Contributor
Author
|
I have refactored the pytests of math.py. Now every wrapper has its own pytest file and a Test_class (even though there are not always multiple tests). Now that I think about it, though, I'm not at all sure that organizing the tests in this way is the best approach. Anyway, I think I'll stick with it for now. Questions: Do we need the file "tests/CMakeLists.txt" ? Is it for conda? |
33d981c to
ca8fb3f
Compare
Collaborator
|
Please rebase (and optionally squash) |
99ac80d to
91baf0e
Compare
Contributor
Author
|
@bnavigator I had some troubles with git, because a "git reset HEAD" I did at some point. I think it should be OK, though. |
Collaborator
|
Thanks @KybernetikJo! For the record, contrary to the initial description of this PR, the test files have not been reorganized, following a discussion in #206. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Slycot/slycot/math.pyin order to be closer to the numpdoc style as discussed in #100.Should be part of #204.
(finished 7 of 7 routines)
Status description: