Conversation
bnavigator
requested changes
May 11, 2020
Collaborator
bnavigator
left a comment
There was a problem hiding this comment.
Nice!
I left a few suggestions that should help render the docstring. I didn't check it myself though, just using the Github suggestion feature of what I think should work.
bnavigator
reviewed
May 11, 2020
bnavigator
reviewed
May 11, 2020
Collaborator
bnavigator
left a comment
There was a problem hiding this comment.
For too small ldwork we can provide a better error message.
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
bnavigator
requested changes
May 11, 2020
Collaborator
bnavigator
left a comment
There was a problem hiding this comment.
A few more minor suggestions if you don't mind 🙃
You can batch the "commit suggestions" and/or add [skip ci] to the commit message to avoid restarting a Travis CI job for every accepted commit.
more docstring fixes accepted. [skip ci] Co-authored-by: Ben Greiner <code@bnavigator.de>
Member
Author
|
With that I think I can merge it myself. |
bnavigator
reviewed
May 11, 2020
Co-authored-by: Ben Greiner <code@bnavigator.de>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding sb10fd, which I hoped would resolve python-control#367. It only gives a specific error for that problem. Adapted to new exception structure.