Merged
Conversation
roryyorke
approved these changes
May 3, 2020
Collaborator
roryyorke
left a comment
There was a problem hiding this comment.
Thanks for this. I find working on the build system can be a bit soul-destroying.
| add_custom_target(wrapper ALL DEPENDS ${FSOURCES}) | ||
| add_custom_command( | ||
| OUTPUT SLYCOTmodule.c _wrappermodule.c _wrapper-f2pywrappers.f | ||
| OUTPUT _wrappermodule.c _wrapper-f2pywrappers.f |
Collaborator
There was a problem hiding this comment.
What happened to SLYCOTmodule.c?
| SLYCOTmodule.c _wrappermodule.c _wrapper-f2pywrappers.f | ||
| "${PYTHON_SITE}/numpy/f2py/src/fortranobject.c" | ||
| _wrappermodule.c | ||
| ${PYTHON_SITE}/numpy/f2py/src/fortranobject.c |
Collaborator
There was a problem hiding this comment.
Just to check: CMake and scikit-build don't find this file for us, or arrange for an "f2py" target that takes care of this?
|
|
||
| target_include_directories( | ||
| ${SLYCOT_MODULE} PUBLIC | ||
| ${PYTHON_SITE}/numpy/core/include |
Collaborator
There was a problem hiding this comment.
Can we use using ${NumPy_INCLUDE_DIR} here?
Collaborator
There was a problem hiding this comment.
I'm also not sure if these should be PUBLIC dependencies of the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes to the CMakeLists.txt files.
Now prints out the numpy header path.