Conversation
for more information, see https://pre-commit.ci
hynek
reviewed
Jun 22, 2022
hynek
requested changes
Jun 23, 2022
Comment on lines
+2278
to
+2280
| assert getattr(object, "__setstate__", None) is getattr( | ||
| C, "__setstate__", None | ||
| ) |
Member
There was a problem hiding this comment.
hm this makes no sense to me…this would pass if both don't exist, and if both are the same thing. this doesn't seem like a good test to me :)
maybe have two asserts, depending on version?
Member
Author
There was a problem hiding this comment.
But... that's what we want. If both don't exist, or both exist and are the same, the functionality is correct. Right?
Member
There was a problem hiding this comment.
uh…i guess i'll take your word for it? it just seems like there's cases where it passes when it shouldn't 🤔
just merge the other shit in then ¯_(ツ)_/¯
|
|
||
| assert None is getattr(i, "__getstate__", None) | ||
| assert None is getattr(i, "__setstate__", None) | ||
| assert getattr(object, "__getstate__", None) is getattr( |
| assert None is getattr(i, "__getstate__", None) | ||
| assert None is getattr(i, "__setstate__", None) | ||
| assert getattr(object, "__getstate__", None) is getattr( | ||
| C, "__getstate__", None |
Member
Author
Member
|
ah sorry, i missed that! |
hynek
added a commit
that referenced
this pull request
Jun 24, 2022
* Add support for Python 3.11 Co-authored-by: Tin Tvrtković <tinchester@gmail.com> * Tin/py311 (#973) * Fix test_slots::TestPickle::test_no_getstate_setstate_for_dict_classes * Fix annotations * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Tweak tests for 3.10 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Tweak tests some more Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tin Tvrtković <tinchester@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.