Merged
Conversation
Values given to `__init__` should now always be propogated to `__attrs_pre_init__`, regardless of default configuration.
for more information, see https://pre-commit.ci
Contributor
Author
|
@hynek Is there anything more I need to do on this PR, or is this not considered a bug? |
Member
|
hey @redruin1 sorry for letting you hang; I've currently too many fires everywhere and am procrastinating to attack the whole pile within attrs. I swear I feel bad and will get around to it! |
hynek
approved these changes
Jul 27, 2025
Member
hynek
left a comment
There was a problem hiding this comment.
Thanks, that was indeed straight-forward! 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Values given to
__init__should now always be propagated to__attrs_pre_init__, regardless of default configuration. Resolves #1427.Pull Request Check List
mainbranch – use a separate branch!.pyi).tests/typing_example.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()and@attrs.define()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives.The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.
attrs.define()andattr.s(), you have to add version directives to both..rstand.mdfiles is written using semantic newlines.changelog.d.