Use an explicit comparison to None for the converter of a field#1374
Merged
hynek merged 1 commit intopython-attrs:mainfrom Nov 25, 2024
Merged
Use an explicit comparison to None for the converter of a field#1374hynek merged 1 commit intopython-attrs:mainfrom
hynek merged 1 commit intopython-attrs:mainfrom
Conversation
5 tasks
Contributor
Author
|
@hynek Would you kindly take a look whenever possible? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make attrs work with a converter instance that does not evaluate True. Other code spots already do an explicit comparison to None, so do that here as well. Failing to do so on a valid converter instance that is a valid callable but has a
__bool__()that evaluates to False ends up trying to call_fmt_converter_callon that callable rather than on the Converter instance created from it.Pull Request Check List
mainbranch – use a separate branch!Our CI fails if coverage is not 100%.
.pyi)..rstand.mdfiles is written using semantic newlines.changelog.d.