Skip to content

Fix crash when __pre_init__, kw_only, and defaults come together#1319

Merged
hynek merged 4 commits intomainfrom
kw-only-defaults-pre-init
Aug 3, 2024
Merged

Fix crash when __pre_init__, kw_only, and defaults come together#1319
hynek merged 4 commits intomainfrom
kw-only-defaults-pre-init

Conversation

@hynek
Copy link
Copy Markdown
Member

@hynek hynek commented Aug 2, 2024

Fixes #1284

@hynek
Copy link
Copy Markdown
Member Author

hynek commented Aug 2, 2024

@zeevro I'm a bit in a rush to release 24.1.0 and I know I let it languish for too long, but if by a wild accident you have a second to look at this, that would be appreciated.

@hynek hynek force-pushed the kw-only-defaults-pre-init branch from 178c9d7 to 0094089 Compare August 2, 2024 07:33
@hynek hynek merged commit 09161fc into main Aug 3, 2024
@hynek hynek deleted the kw-only-defaults-pre-init branch August 3, 2024 11:31
@zeevro
Copy link
Copy Markdown

zeevro commented Aug 3, 2024

Sorry, I only got to it now, but the issue seems to be solved and everything looks like it's working :)
Thanks a lot!

@hynek
Copy link
Copy Markdown
Member Author

hynek commented Aug 3, 2024

hah releasing is the best way to get feedback either way ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kw_only with default breaks __attrs_pre_init__ call

2 participants