Open
Conversation
664ace3 to
24fc248
Compare
From https://man.archlinux.org/man/vsock.7: > The VSOCK address family facilitates communication between virtual machines and the host they are running on. An example: https://wiki.archlinux.org/title/QEMU#Accessing_SSH_via_vsock The separator between the "vsock" identifier and the CID can either be a forward slash (`/`) or a percent sign (`%`). `urllib.parse.urlparse` will mistake the forward slash for the beginning of the URL path, but a percent sign is accepted. ``` >>> urlparse("ansible://vsock/555") ParseResult(scheme='ansible', netloc='vsock', path='/555', params='', query='', fragment='') >>> urlparse("ansible://vsock%555") ParseResult(scheme='ansible', netloc='vsock%555', path='', params='', query='', fragment='') ```
24fc248 to
dd13311
Compare
francoisfreitag
commented
Feb 28, 2026
| spec += "[" + testinfra_host + "]" | ||
| else: | ||
| spec += testinfra_host | ||
| spec += urllib.parse.quote(testinfra_host) |
Contributor
Author
There was a problem hiding this comment.
This matches
pytest-testinfra/testinfra/backend/base.py
Line 260 in c17794e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://man.archlinux.org/man/vsock.7:
An example: https://wiki.archlinux.org/title/QEMU#Accessing_SSH_via_vsock
The separator between the "vsock" identifier and the CID can either be a forward slash (
/) or a percent sign (%).urllib.parse.urlparsewill mistake the forward slash for the beginning of the URL path, but a percent sign is accepted.