Detect shell-script Python executables in ScriptMaker shebangs#264
Open
l46983284-cpu wants to merge 1 commit into
Open
Detect shell-script Python executables in ScriptMaker shebangs#264l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
Nix and similar installs may provide a shell-script wrapper as the Python executable. ScriptMaker only applied that check on Jython, so POSIX shebangs could point at a nested script interpreter. Lift _is_shell() to ScriptMaker for all platforms and force the safe multi-line shebang when the configured executable starts with #!. Fixes pypa#144 Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #144.
ScriptMakeronly treated shell-script Python executables specially on Jython. On ordinary POSIX, a Nix-style wrapper (a bash script thatexecs the real interpreter) could still be written into a simple#!shebang.This change:
_is_shell()ontoScriptMakerfor all platforms#!Test plan
cd tests && PYTHONPATH=..:. python3 -m unittest test_scripts -v→ OK (21 tests, 5 Windows skips)test_shell_script_executable_shebangpassestest_utilfailures reproduce on cleanmaster(not introduced here)