Skip to content

Use definition of DTypeLike from Numpy if found #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 2 commits into from
Feb 23, 2021
Merged

Use definition of DTypeLike from Numpy if found #4941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30706b8
Use definition of DTypeLike from Numpy
jenshnielsen Feb 22, 2021
35c36b8
fix flake8
jenshnielsen Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions xarray/core/npcompat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,12 @@ def moveaxis(a, source, destination):
return result


# Type annotations stubs. See also / to be replaced by:
# https://github.com/numpy/numpy/issues/7370
# https://github.com/numpy/numpy-stubs/
DTypeLike = Union[np.dtype, str]
# Type annotations stubs.
try:
from numpy.typing import DTypeLike
except ImportError:
# fall back for numpy < 1.20
DTypeLike = Union[np.dtype, str]


# from dask/array/utils.py
Expand Down